Allow index & cluster default refresh interval setting value to be -1 #11411

ashking94 · 2023-11-30T11:37:43Z

Description

This PR fixes the bug that does not allow the index setting index.refresh_interval and cluster setting cluster.default.index.refresh_interval to be set to -1. More details on #11410.

Related Issues

Resolves #11410

Check List

New functionality includes testing.
- All tests pass
New functionality has been documented.
- New functionality has javadoc added
Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
Commits are signed per the DCO using --signoff
~~Commit changes are listed out in CHANGELOG.md file (See: Changelog)~~
~~Public documentation issue/PR created~~

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

github-actions · 2023-11-30T12:00:02Z

Compatibility status:

Checks if related components are compatible with change e111d4f

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/performance-analyzer.git]

github-actions · 2023-11-30T12:57:01Z

❕ Gradle check result for e0d6240: UNSTABLE

TEST FAILURES:

      3 org.opensearch.remotestore.RemoteIndexPrimaryRelocationIT.testPrimaryRelocationWhileIndexing

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

codecov · 2023-11-30T12:57:37Z

Codecov Report

Attention: Patch coverage is 50.00000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 71.48%. Comparing base (b15cb0c) to head (566fbe0).
Report is 220 commits behind head on main.

Files	Patch %	Lines
...in/java/org/opensearch/indices/IndicesService.java	0.00%	1 Missing and 1 partial ⚠️
...h/cluster/metadata/MetadataCreateIndexService.java	75.00%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               main   #11411      +/-   ##
============================================
+ Coverage     71.42%   71.48%   +0.06%     
- Complexity    59978    60722     +744     
============================================
  Files          4985     5044      +59     
  Lines        282275   285704    +3429     
  Branches      40946    41374     +428     
============================================
+ Hits         201603   204226    +2623     
- Misses        63999    64568     +569     
- Partials      16673    16910     +237

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ashking94 · 2023-11-30T13:03:59Z

testPrimaryRelocationWhileIndexing

flaky test - #9191

ashking94 · 2023-12-01T15:25:13Z

❌ Gradle check result for fb11796: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Flaky test - #9891

Signed-off-by: Ashish Singh <[email protected]>

github-actions · 2023-12-01T15:58:06Z

❌ Gradle check result for af98af1: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: Ashish Singh <[email protected]>

github-actions · 2023-12-02T04:21:14Z

❕ Gradle check result for e111d4f: UNSTABLE

TEST FAILURES:

      1 org.opensearch.repositories.azure.AzureBlobStoreRepositoryTests.testRequestStats

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

server/src/main/java/org/opensearch/indices/IndicesService.java

Bukhtawar

Will prefer a more predictable value rather than disabling a mode meant to perform constant work in the system(segment creation and replication)

ashking94 · 2023-12-18T05:12:08Z

Will prefer a more predictable value rather than disabling a mode meant to perform constant work in the system(segment creation and replication)

Can you elaborate more on this, @Bukhtawar?

opensearch-trigger-bot · 2024-01-17T15:20:48Z

This PR is stalled because it has been open for 30 days with no activity.

gbbafna · 2024-04-25T05:43:03Z

@astute-decipher : can you pick this one and rebase it ?

github-actions · 2024-04-25T06:14:10Z

❌ Gradle check result for e111d4f: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

ashking94 · 2024-04-25T06:23:09Z

@gbbafna let me do that for you. @astute-decipher might not have the access for it.

Signed-off-by: Ashish Singh <[email protected]>

github-actions · 2024-04-25T07:20:46Z

❕ Gradle check result for 566fbe0: UNSTABLE

TEST FAILURES:

      1 org.opensearch.gateway.RecoveryFromGatewayIT.testShardStoreFetchMultiNodeMultiIndexesUsingBatchAction

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

ashking94 · 2024-04-25T08:34:59Z

testShardStoreFetchMultiNodeMultiIndexesUsingBatchAction

Flaky test - #13307

…#11411) Signed-off-by: Ashish Singh <[email protected]> (cherry picked from commit 42d46a9) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

…#11411) (#13380) (cherry picked from commit 42d46a9) Signed-off-by: Ashish Singh <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

ashking94 force-pushed the 11410 branch from e0d6240 to 6029a81 Compare November 30, 2023 12:59

github-actions bot added bug Something isn't working Storage:Durability Issues and PRs related to the durability framework labels Nov 30, 2023

ashking94 added the skip-changelog label Nov 30, 2023

ashking94 marked this pull request as ready for review November 30, 2023 13:05

ashking94 requested review from abbashus, adnapibar, anasalkouz, andrross, Bukhtawar, CEHENKLE, dblock, dbwiddis, dreamer-89, gbbafna, kartg, kotwanikunal, mch2, msfroh, nknize, owaiskazi19, peternied, reta, Rishikesh1159, ryanbogan and sachinpkale as code owners November 30, 2023 13:05

ashking94 added 2 commits December 1, 2023 20:55

Allow index & cluster default refresh interval setting value to be -1

c7f4531

Signed-off-by: Ashish Singh <[email protected]>

Incorporare PR review comments

af98af1

Signed-off-by: Ashish Singh <[email protected]>

ashking94 force-pushed the 11410 branch from fb11796 to af98af1 Compare December 1, 2023 15:26

kkmr approved these changes Dec 1, 2023

View reviewed changes

Empty-Commit

e111d4f

Signed-off-by: Ashish Singh <[email protected]>

sachinpkale reviewed Dec 7, 2023

View reviewed changes

server/src/main/java/org/opensearch/indices/IndicesService.java Show resolved Hide resolved

sachinpkale approved these changes Dec 7, 2023

View reviewed changes

Bukhtawar reviewed Dec 7, 2023

View reviewed changes

opensearch-trigger-bot bot added stalled Issues that have stalled and removed stalled Issues that have stalled labels Jan 17, 2024

ashking94 closed this Feb 20, 2024

gbbafna reopened this Apr 25, 2024

Merge remote-tracking branch 'upstream/main' into 11410

566fbe0

Signed-off-by: Ashish Singh <[email protected]>

gbbafna approved these changes Apr 25, 2024

View reviewed changes

gbbafna added the backport 2.x Backport to 2.x branch label Apr 25, 2024

gbbafna merged commit 42d46a9 into opensearch-project:main Apr 25, 2024
30 of 31 checks passed

gbbafna deleted the 11410 branch April 25, 2024 08:37

opensearch-trigger-bot bot mentioned this pull request Apr 25, 2024

[Backport 2.x] Allow index & cluster default refresh interval setting value to be -1 #13380

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Allow index & cluster default refresh interval setting value to be -1 #11411

Allow index & cluster default refresh interval setting value to be -1 #11411

ashking94 commented Nov 30, 2023 •

edited

Loading

github-actions bot commented Nov 30, 2023 •

edited

Loading

github-actions bot commented Nov 30, 2023

codecov bot commented Nov 30, 2023 •

edited

Loading

ashking94 commented Nov 30, 2023

ashking94 commented Dec 1, 2023

github-actions bot commented Dec 1, 2023

github-actions bot commented Dec 2, 2023

Bukhtawar left a comment

ashking94 commented Dec 18, 2023

opensearch-trigger-bot bot commented Jan 17, 2024

gbbafna commented Apr 25, 2024

github-actions bot commented Apr 25, 2024

ashking94 commented Apr 25, 2024

github-actions bot commented Apr 25, 2024

ashking94 commented Apr 25, 2024

Allow index & cluster default refresh interval setting value to be -1 #11411

Allow index & cluster default refresh interval setting value to be -1 #11411

Conversation

ashking94 commented Nov 30, 2023 • edited Loading

Description

Related Issues

Check List

github-actions bot commented Nov 30, 2023 • edited Loading

Compatibility status:

Incompatible components

Skipped components

Compatible components

github-actions bot commented Nov 30, 2023

codecov bot commented Nov 30, 2023 • edited Loading

Codecov Report

ashking94 commented Nov 30, 2023

ashking94 commented Dec 1, 2023

github-actions bot commented Dec 1, 2023

github-actions bot commented Dec 2, 2023

Bukhtawar left a comment

Choose a reason for hiding this comment

ashking94 commented Dec 18, 2023

opensearch-trigger-bot bot commented Jan 17, 2024

gbbafna commented Apr 25, 2024

github-actions bot commented Apr 25, 2024

ashking94 commented Apr 25, 2024

github-actions bot commented Apr 25, 2024

ashking94 commented Apr 25, 2024

ashking94 commented Nov 30, 2023 •

edited

Loading

github-actions bot commented Nov 30, 2023 •

edited

Loading

codecov bot commented Nov 30, 2023 •

edited

Loading